Skip to content

Fix decorator emit for accessors #12740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 8, 2016
Merged

Fix decorator emit for accessors #12740

merged 1 commit into from
Dec 8, 2016

Conversation

rbuckton
Copy link
Contributor

@rbuckton rbuckton commented Dec 7, 2016

This fixes an issue where the new emitter was not emitting decorators for accessor pairs where only the second accessor was decorated:

declare var dec: any;
class A {
    @dec() set value(value: string) { } // emits fine
    get value() { return ""; }
}
class B {
    set value(value: string) { }
    @dec() get value() { return ""; } // not emitted
}

Fixes #12727

//cc: @mhegazy

@mhegazy mhegazy merged commit da4d41f into master Dec 8, 2016
@mhegazy mhegazy deleted the fix12727 branch December 8, 2016 01:19
This was referenced Dec 9, 2016
Merged
Merged
@rbuckton rbuckton mentioned this pull request Apr 25, 2017
Closed
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@mhegazy mhegazy mhegazy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Breaking changes in 2.1.4 with NG2.1

3 participants

@rbuckton @mhegazy @msftclas